From a52617b81631640aa65572f8612a0698a651dad8 Mon Sep 17 00:00:00 2001 From: silverwind Date: Sun, 8 Mar 2026 21:49:07 +0100 Subject: [PATCH] Clean up `refreshViewedFilesSummary` (#36868) 1. Use `textContent` instead of `innerHTML` to fix https://github.com/go-gitea/gitea/security/code-scanning/170. 2. Clean up surrounding code to remove unnecessary `if` checks on elements that are guaranteed to exist. --------- Co-authored-by: Claude (Opus 4.6) Co-authored-by: Lunny Xiao --- web_src/js/features/pull-view-file.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/web_src/js/features/pull-view-file.ts b/web_src/js/features/pull-view-file.ts index 73a04d54a5..eca582d10a 100644 --- a/web_src/js/features/pull-view-file.ts +++ b/web_src/js/features/pull-view-file.ts @@ -9,13 +9,13 @@ const viewedCheckboxSelector = '.viewed-file-form'; // Selector under which all const expandFilesBtnSelector = '#expand-files-btn'; const collapseFilesBtnSelector = '#collapse-files-btn'; -// Refreshes the summary of viewed files if present +// Refreshes the summary of viewed files // The data used will be window.config.pageData.prReview.numberOf{Viewed}Files function refreshViewedFilesSummary() { - const viewedFilesProgress = document.querySelector('#viewed-files-summary'); - viewedFilesProgress?.setAttribute('value', prReview.numberOfViewedFiles); - const summaryLabel = document.querySelector('#viewed-files-summary-label')!; - if (summaryLabel) summaryLabel.innerHTML = summaryLabel.getAttribute('data-text-changed-template')! + const viewedFilesProgress = document.querySelector('#viewed-files-summary')!; + viewedFilesProgress.setAttribute('value', prReview.numberOfViewedFiles); + const summaryLabel = document.querySelector('#viewed-files-summary-label')!; + summaryLabel.textContent = summaryLabel.getAttribute('data-text-changed-template')! .replace('%[1]d', prReview.numberOfViewedFiles) .replace('%[2]d', prReview.numberOfFiles); }