Replace index with id in actions routes (#36842)

This PR migrates the web Actions run/job routes from index-based
`runIndex` or `jobIndex` to database IDs.

**⚠️ BREAKING ⚠️**: Existing saved links/bookmarks that use the old
index-based URLs will no longer resolve after this change.

Improvements of this change:
- Previously, `jobIndex` depended on list order, making it hard to
locate a specific job. Using `jobID` provides stable addressing.
- Web routes now align with API, which already use IDs.
- Behavior is closer to GitHub, which exposes run/job IDs in URLs.
- Provides a cleaner base for future features without relying on list
order.
- #36388 this PR improves the support for reusable workflows. If a job
uses a reusable workflow, it may contain multiple child jobs, which
makes relying on job index to locate a job much more complicated

---------

Signed-off-by: Zettat123 <zettat123@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

services/actions/commit_status.go

@@ -56,21 +56,21 @@ func CreateCommitStatusForRunJobs(ctx context.Context, run *actions_model.Action
 func GetRunsFromCommitStatuses(ctx context.Context, statuses []*git_model.CommitStatus) ([]*actions_model.ActionRun, error) {
 	runMap := make(map[int64]*actions_model.ActionRun)
 	for _, status := range statuses {
-		runIndex, _, ok := status.ParseGiteaActionsTargetURL(ctx)
+		runID, _, ok := status.ParseGiteaActionsTargetURL(ctx)
 		if !ok {
 			continue
 		}
-		_, ok = runMap[runIndex]
+		_, ok = runMap[runID]
 		if !ok {
-			run, err := actions_model.GetRunByIndex(ctx, status.RepoID, runIndex)
+			run, err := actions_model.GetRunByRepoAndID(ctx, status.RepoID, runID)
 			if err != nil {
 				if errors.Is(err, util.ErrNotExist) {
 					// the run may be deleted manually, just skip it
 					continue
 				}
-				return nil, fmt.Errorf("GetRunByIndex: %w", err)
+				return nil, fmt.Errorf("GetRunByRepoAndID: %w", err)
 			}
-			runMap[runIndex] = run
+			runMap[runID] = run
 		}
 	}
 	runs := make([]*actions_model.ActionRun, 0, len(runMap))
@@ -181,15 +181,10 @@ func createCommitStatus(ctx context.Context, repo *repo_model.Repository, event,
 		description = "Unknown status: " + strconv.Itoa(int(job.Status))
 	}
 
-	index, err := getIndexOfJob(ctx, job)
-	if err != nil {
-		return fmt.Errorf("getIndexOfJob: %w", err)
-	}
-
 	creator := user_model.NewActionsUser()
 	status := git_model.CommitStatus{
 		SHA:         commitID,
-		TargetURL:   fmt.Sprintf("%s/jobs/%d", run.Link(), index),
+		TargetURL:   fmt.Sprintf("%s/jobs/%d", run.Link(), job.ID),
 		Description: description,
 		Context:     ctxName,
 		CreatorID:   creator.ID,
@@ -213,17 +208,3 @@ func toCommitStatus(status actions_model.Status) commitstatus.CommitStatusState
 		return commitstatus.CommitStatusError
 	}
 }
-
-func getIndexOfJob(ctx context.Context, job *actions_model.ActionRunJob) (int, error) {
-	// TODO: store job index as a field in ActionRunJob to avoid this
-	jobs, err := actions_model.GetRunJobsByRunID(ctx, job.RunID)
-	if err != nil {
-		return 0, err
-	}
-	for i, v := range jobs {
-		if v.ID == job.ID {
-			return i, nil
-		}
-	}
-	return 0, nil
-}

services/actions/rerun.go

@@ -148,6 +148,9 @@ func rerunWorkflowJob(ctx context.Context, job *actions_model.ActionRunJob, shou
 	if err := job.LoadRun(ctx); err != nil {
 		return err
 	}
+	if err := job.Run.LoadAttributes(ctx); err != nil {
+		return err
+	}
 
 	vars, err := actions_model.GetVariablesOfRun(ctx, job.Run)
 	if err != nil {

services/convert/convert.go

@@ -324,18 +324,6 @@ func ToActionWorkflowJob(ctx context.Context, repo *repo_model.Repository, task
 		return nil, err
 	}
 
-	jobIndex := 0
-	jobs, err := actions_model.GetRunJobsByRunID(ctx, job.RunID)
-	if err != nil {
-		return nil, err
-	}
-	for i, j := range jobs {
-		if j.ID == job.ID {
-			jobIndex = i
-			break
-		}
-	}
-
 	status, conclusion := ToActionsStatus(job.Status)
 	var runnerID int64
 	var runnerName string
@@ -379,7 +367,7 @@ func ToActionWorkflowJob(ctx context.Context, repo *repo_model.Repository, task
 		ID: job.ID,
 		// missing api endpoint for this location
 		URL:     fmt.Sprintf("%s/actions/jobs/%d", repo.APIURL(), job.ID),
-		HTMLURL: fmt.Sprintf("%s/jobs/%d", job.Run.HTMLURL(), jobIndex),
+		HTMLURL: fmt.Sprintf("%s/jobs/%d", job.Run.HTMLURL(), job.ID),
 		RunID:   job.RunID,
 		// Missing api endpoint for this location, artifacts are available under a nested url
 		RunURL:      fmt.Sprintf("%s/actions/runs/%d", repo.APIURL(), job.RunID),